DM-52258: Only run glint detection on good diaSources #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is really meant to catch cases where diaSources is an empty catalog, and attempting to set the column even to an empty array will raise a `TypeError`
mrawls
reviewed
Aug 21, 2025
Contributor
mrawls
left a comment
mrawls
left a comment
There was a problem hiding this comment.
Thanks for this improvement - I agree catching glints after removing unphysical sources and making sure we aren't letting sky sources be part of a glint trail is what we want. Just one clarifying question I'd like to understand before hitting "approve."
Comment on lines
+909
to
+910
| if np.any(glint_mask): | ||
| diaSources['glint_trail'] = np.array(glint_mask) |
Contributor
There was a problem hiding this comment.
If there are in fact diaSources, and glint_mask is full of False, wouldn't this leave the column empty?
Contributor
Author
There was a problem hiding this comment.
No, diaSources['glint_trail'] is all False before this line, not empty.
Contributor
There was a problem hiding this comment.
Ah ok, so self.schema.addField("glint_trail", "Flag", "DiaSource is part of a glint trail.") creates the column AND sets it default False? The more you know 🌈
mrawls
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.